Skip site navigation (1) Skip section navigation (2)

Re: [v9.2] make_greater_string() does not return a string in some cases

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases
Date: 2011-10-29 19:35:27
Message-ID: 28652.1319916927@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> I've committed this, after a good deal of hacking on the comments,
> some coding style cleanup, and one bug fix:

Ummm ... why do the incrementer functions think they need to restore the
previous value on failure?  AFAICS that's a waste of code and cycles,
since there is only one caller and it doesn't care in the least.

I'm also quite distressed that you ignored my advice to limit the number
of combinations tried.  This patch could be horribly slow when dealing
with wide characters, eg think what will happen when starting from
U+10000.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Robert HaasDate: 2011-10-29 20:07:02
Subject: Re: pg_upgrade if 'postgres' database is dropped
Previous:From: Tom LaneDate: 2011-10-29 19:13:00
Subject: Re: strange code in array_in

pgsql-bugs by date

Next:From: Robert HaasDate: 2011-10-29 20:15:16
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases
Previous:From: Robert HaasDate: 2011-10-29 18:26:28
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group