Re: Concurrent psql patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, David Fetter <david(at)fetter(dot)org>, Jim Nasby <decibel(at)decibel(dot)org>, pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Concurrent psql patch
Date: 2007-05-24 05:16:34
Message-ID: 28417.1179983794@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> There are some places that it doesn't use PG style (e.g. no newline
> before brace after if) and some comments that need to be fixed (e.g. /*
> XXX get result */ )

Of course you both realize pgindent will take care of the former ;-).
But yes, bogus comments are worth the trouble to fix now.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Shachar Shemesh 2007-05-24 05:24:58 Re: Re: [Oledb-dev] double precision error with pg linux server, but not with windows pg server
Previous Message Andrew Dunstan 2007-05-24 03:59:37 Re: Concurrent psql patch

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-05-24 17:17:47 Re: like/ilike improvements
Previous Message Andrew Dunstan 2007-05-24 03:59:37 Re: Concurrent psql patch