Skip site navigation (1) Skip section navigation (2)

Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Marcin Kowalski <kowalski(at)datrix(dot)co(dot)za>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP
Date: 2001-04-01 00:53:39
Message-ID: 28177.986086419@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-adminpgsql-bugspgsql-generalpgsql-hackerspgsql-sql
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> First, here is a patch which will prevent this from happening in the
> future.  Do people want this held for 7.2 or applied now?  It disables
> the creation of user indexes on system tables.
  
> + 	if (heapRelationName && !allow_system_table_mods &&
> + 		IsSystemRelationName(heapRelationName) && IsNormalProcessingMode())
> + 	{
> + 		elog(ERROR, "You can not create indexes on system tables:  '%s'",
> + 			 heapRelationName);
> + 	}
> + 

I think it would be a real good idea to put in this safeguard, but
I don't much like that error message.  How about

    elog(ERROR, "User-defined indexes on system catalogs are not supported");


			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2001-04-01 00:58:17
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP
Previous:From: Tom LaneDate: 2001-04-01 00:44:30
Subject: Re: Re: Changing the default value of an inherited column

pgsql-sql by date

Next:From: Bruce MomjianDate: 2001-04-01 00:58:17
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP
Previous:From: Tom LaneDate: 2001-04-01 00:18:26
Subject: Re: Vacuum Error

pgsql-admin by date

Next:From: Bruce MomjianDate: 2001-04-01 00:58:17
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP
Previous:From: Tom LaneDate: 2001-04-01 00:14:59
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

pgsql-bugs by date

Next:From: Bruce MomjianDate: 2001-04-01 00:58:17
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP
Previous:From: Tom LaneDate: 2001-04-01 00:14:59
Subject: Re: Re: [SQL] Re: pg_dump potential bug -UNIQUE INDEX on PG_SHADOW Dont!! HELP

pgsql-general by date

Next:From: Bruce MomjianDate: 2001-04-01 00:55:40
Subject: Re: Re: Memory Tuning
Previous:From: Tom LaneDate: 2001-04-01 00:30:18
Subject: Re: Re: Memory Tuning

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group