Re: Avg performance for int8/numeric

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, Neil Conway <neilc(at)samurai(dot)com>
Cc: Mark Kirkwood <markir(at)paradise(dot)net(dot)nz>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, "eng(at)intranet(dot)greenplum(dot)com" <eng(at)intranet(dot)greenplum(dot)com>
Subject: Re: Avg performance for int8/numeric
Date: 2006-11-24 04:18:12
Message-ID: 28127.1164341892@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> On Fri, 2006-11-24 at 11:08 +1300, Mark Kirkwood wrote:
>> - Modifies do_numeric_accum to have an extra bool parameter and does not
>> calc sumX2 when it is false.

> I think it would be clearer to reorganize this function slightly, and
> have only a single branch on "useSumX2".

It would be clearer to just have a separate function.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira de Oliveira 2006-11-24 09:24:12 Re: Day and month name localization uses wrong locale category
Previous Message Neil Conway 2006-11-24 04:09:25 Re: Avg performance for int8/numeric

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-11-24 15:27:10 Re: Avg performance for int8/numeric
Previous Message Neil Conway 2006-11-24 04:09:25 Re: Avg performance for int8/numeric