Skip site navigation (1) Skip section navigation (2)

Re: small regression script improvement

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: small regression script improvement
Date: 2006-06-18 22:44:38
Message-ID: 27185.1150670678@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> This suggested patch makes sure that the regression script can actually 
> connect to the database rather than falling through after 60 seconds, as 
> discussed on -hackers.

Oh, I see what you mean.  But surely that's the hard way.  The script
should just fail where it currently "break"s out of the loop.  It's
not any longer and it permits a more specific error message.

			regards, tom lane

*** src/test/regress/pg_regress.sh.orig	Wed Jan  4 22:01:38 2006
--- src/test/regress/new/pg_regress.sh	Sun Jun 18 18:42:24 2006
***************
*** 446,472 ****
          i=`expr $i + 1`
          if [ $i -ge $max ]
          then
!             break
          fi
          if kill -0 $postmaster_pid >/dev/null 2>&1
          then
              : still starting up
          else
!             break
          fi
          sleep 1
      done
  
!     if kill -0 $postmaster_pid >/dev/null 2>&1
!     then
!         echo "running on port $PGPORT with pid $postmaster_pid"
!     else
!         echo
!         echo "$me: postmaster did not start"
!         echo "Examine $LOGDIR/postmaster.log for the reason."
!         echo
!         (exit 2); exit
!     fi
  
  else # not temp-install
  
--- 446,473 ----
          i=`expr $i + 1`
          if [ $i -ge $max ]
          then
!             : timeout
!             echo
!             echo "$me: postmaster is not accepting connections"
!             echo "Examine $LOGDIR/postmaster.log for the reason."
!             echo
!             (exit 2); exit
          fi
          if kill -0 $postmaster_pid >/dev/null 2>&1
          then
              : still starting up
          else
!             : postmaster failed
!             echo
!             echo "$me: postmaster failed"
!             echo "Examine $LOGDIR/postmaster.log for the reason."
!             echo
!             (exit 2); exit
          fi
          sleep 1
      done
  
!     echo "running on port $PGPORT with pid $postmaster_pid"
  
  else # not temp-install
  

In response to

Responses

pgsql-patches by date

Next:From: Andrew DunstanDate: 2006-06-18 23:14:11
Subject: Re: small regression script improvement
Previous:From: Andrew DunstanDate: 2006-06-18 22:20:57
Subject: small regression script improvement

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group