Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Jan Wieck <JanWieck(at)Yahoo(dot)com>, Claudio Natoli <claudio(dot)natoli(at)memetrics(dot)com>, "''pgsql-patches(at)postgresql(dot)org' '" <pgsql-patches(at)postgresql(dot)org>, PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization
Date: 2004-01-09 23:22:18
Message-ID: 27027.1073690538@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Claudio specified the attached fix, which I have applied (this time).

The ereport must vanish back into its black hole, also.
ProcessStartupPacket has already issued any appropriate log message.

> *** 2450,2456 ****
> {
> ereport(LOG,
> (errmsg("connection startup failed")));
> ! proc_exit(status);
> }

> /*
> --- 2450,2456 ----
> {
> ereport(LOG,
> (errmsg("connection startup failed")));
> ! proc_exit(0);
> }

> /*

regards, tom lane

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Bruce Momjian 2004-01-09 23:26:56 Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization
Previous Message Bruce Momjian 2004-01-09 23:11:28 Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-01-09 23:26:56 Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization
Previous Message Bruce Momjian 2004-01-09 23:11:28 Re: [PATCHES] fork/exec patch: pre-CreateProcess finalization