Skip site navigation (1) Skip section navigation (2)

Re: Two coverity non-bugs

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martijn van Oosterhout <kleptog(at)svana(dot)org>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Two coverity non-bugs
Date: 2006-04-19 15:26:34
Message-ID: 26466.1145460394@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> Note, what coverity actually picked up was that in the latter case in
> _selectOutputSchema that the free will always execute because if
> AH->currSchema was NULL it would have died at the beginning of the
> function (line 2205). It's me who misinterpreted the fix. We should
> probably be adding checks to all the strdups and to line 2205 instead.

Ah, OK, so it wasn't doing this on the basis of a global determination
that currSchema couldn't be NULL.  That makes more sense then.  I agree
that line 2205 would be more consistent if it checked for null currSchema.

			regards, tom lane

In response to

pgsql-patches by date

Next:From: Martijn van OosterhoutDate: 2006-04-19 15:36:21
Subject: [PATCH] Tiny memleak in libpq
Previous:From: Peter BrantDate: 2006-04-19 15:16:42
Subject: Re: pgstat: remove delayed destroy / pipe:

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group