From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
Cc: | pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Two coverity non-bugs |
Date: | 2006-04-19 15:26:34 |
Message-ID: | 26466.1145460394@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Martijn van Oosterhout <kleptog(at)svana(dot)org> writes:
> Note, what coverity actually picked up was that in the latter case in
> _selectOutputSchema that the free will always execute because if
> AH->currSchema was NULL it would have died at the beginning of the
> function (line 2205). It's me who misinterpreted the fix. We should
> probably be adding checks to all the strdups and to line 2205 instead.
Ah, OK, so it wasn't doing this on the basis of a global determination
that currSchema couldn't be NULL. That makes more sense then. I agree
that line 2205 would be more consistent if it checked for null currSchema.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Martijn van Oosterhout | 2006-04-19 15:36:21 | [PATCH] Tiny memleak in libpq |
Previous Message | Peter Brant | 2006-04-19 15:16:42 | Re: pgstat: remove delayed destroy / pipe: |