Skip site navigation (1) Skip section navigation (2)

Re: fixing REL7_3_STABLE build issues

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fixing REL7_3_STABLE build issues
Date: 2005-07-16 15:45:47
Message-ID: 26233.1121528747@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> The attached (new) src/test/regress/expected/geometry_9.out, intended 
> only for the 7.3 stable branch,  allows a clean regression pass on my 
> FC4 box. I called it that to avoid conflicts with other geometry_n files 
> on later branches.

I'd like to have a more principled approach to fixing the back branches
than "we'll do whatever it takes to have a clean buildfarm board on the
set of machines that happen to have volunteered to run buildfarm on that
branch".

The geometry test has been such a consistent bugaboo that I'd sooner
remove it from the back branch test lists than follow the path your
proposal leads down.  I can see we'd need at least one more geometry
instance immediately in the 7.3 branch, and what about 7.2?

> The attached patch for contrib/seg/segparse.y allows a clean 7.3 contrib 
> build. The latter fix looks like one that should be made on the 7.4 
> branch also - man 3 errno on my box says:

Agreed --- this is outright unportable code.  Patched in 7.2-7-4.
(It may be that 7.4 fails to fail on your machine because it's already
included <errno.h> by way of c.h, but the extern is an invitation to
trouble in any case.)

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Kris JurkaDate: 2005-07-16 16:00:12
Subject: Re: fixing REL7_3_STABLE build issues
Previous:From: Kris JurkaDate: 2005-07-16 15:22:10
Subject: Re: [HACKERS] 4 pgcrypto regressions failures - 1 unsolved

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group