Skip site navigation (1) Skip section navigation (2)

Re: vacuum hint on elog

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: vacuum hint on elog
Date: 2005-01-22 21:20:59
Message-ID: 25395.1106428859@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Neil Conway <neilc(at)samurai(dot)com> writes:
> It occurred to me that if we elog(ERROR) during VACUUM, the vacuum 
> activity hint will not be reset.

The code beginning at freelist.c line 645 is intended to deal with this.

> Attached is a patch which resets the vacuum activity hint in 
> AbortTransaction().

I dislike exposing such low-level issues to AbortTransaction().
If an explicit reset is needed, there should be something like
an AtAbort_Buffers() call that does this as well as any other
low-level issues needed (eg AbortBufferIO()).  Note that you
missed AbortSubTransaction() anyway.

			regards, tom lane

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-01-22 22:05:55
Subject: Re: bug in 8.0 manual, section 37.6, PL/Perl Triggers
Previous:From: Bruce MomjianDate: 2005-01-22 21:19:16
Subject: Re: Much Ado About COUNT(*)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group