Re: WIN32 errno patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Bruce Momjian - CVS <momjian(at)hub(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIN32 errno patch
Date: 2001-07-21 22:09:28
Message-ID: 24188.995753368@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> At this point, I am just happy we have this WIN32 errno thing working.

My point is that it isn't "working", it's broken.

> My guess is that we should have two errno's. One the normal errno that
> is the same on Win32 and Unix and a sockerrno that is conditionally
> defined:

I don't really want to uglify the code by replacing most of the "errno"
uses with "sockerrno". People know what errno is, they don't know what
"sockerrno" is, so we'd be reducing the readability of the code in order
to cater to Windows cultural imperialism (usual M$ philosophy: embrace,
extend, and make sure Windows-compatible code can't run anywhere else).

Since there are only about three routines in libpq that need access to
"regular" errno, it seems less invasive to #define errno for the rest
of them, and do something special in just these places.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2001-07-22 22:01:04 pgsql/src/backend/access/transam xlog.c
Previous Message Bruce Momjian 2001-07-21 21:35:45 Re: WIN32 errno patch

Browse pgsql-hackers by date

  From Date Subject
Next Message Philip Warner 2001-07-22 00:22:48 Re: Incomplete idea about views and INSERT...RETURNING
Previous Message Tom Lane 2001-07-21 22:03:45 Incomplete idea about views and INSERT...RETURNING

Browse pgsql-patches by date

  From Date Subject
Next Message Philip Warner 2001-07-22 00:10:45 Re: New EXPLAIN ANALYZE statement
Previous Message Bruce Momjian 2001-07-21 21:35:45 Re: WIN32 errno patch