Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] ident authentication fails on kFreeBSD/x86-64 due to wrong struct size

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Martin Pitt <mpitt(at)debian(dot)org>
Cc: PostgreSQL Bugs <pgsql-bugs(at)postgresql(dot)org>, Petr Salinger <Petr(dot)Salinger(at)seznam(dot)cz>, 612888(at)bugs(dot)debian(dot)org
Subject: Re: [PATCH] ident authentication fails on kFreeBSD/x86-64 due to wrong struct size
Date: 2011-05-29 18:08:33
Message-ID: 24047.1306692513@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-bugs
Martin Pitt <mpitt(at)debian(dot)org> writes:
>  	/* Compute size without padding */
> -	char		cmsgmem[ALIGN(sizeof(struct cmsghdr)) + ALIGN(sizeof(Cred))];	/* for NetBSD */
> +	char		cmsgmem[ALIGN(sizeof(struct cmsghdr)) + sizeof(Cred)];	/* for NetBSD */

Hm.  That code's been like that for a very long time (since 2001
according to the git history...).  How much confidence can we have
that this change won't result in breakage on other flavors of *BSD?

(I'm unable to test this myself, not having any platforms on which
this branch of auth_peer gets compiled...)

			regards, tom lane

In response to

Responses

pgsql-bugs by date

Next:From: Tom LaneDate: 2011-05-29 18:49:43
Subject: Re: [PATCH] ident authentication fails on kFreeBSD/x86-64 due to wrong struct size
Previous:From: Emanuel CalvoDate: 2011-05-29 15:56:23
Subject: Re: BUG #6045: Compilation of contribs fail

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group