Oliver Elphick <olly(at)lfix(dot)co(dot)uk> writes:
> -       strerror_r(errnum, strerrbuf, buflen);
> +       char buf[256];
> +       StrNCpy(strerrbuf, strerror_r(errnum, buf, 256), buflen);
>         return strerrbuf;

Easier and safer would be

> -       strerror_r(errnum, strerrbuf, buflen);
> -       return strerrbuf;
> +       return strerror_r(errnum, strerrbuf, buflen);

The real point here is that we need to code differently depending on
which flavor of strerror_r we have.

			regards, tom lane

In response to

• Re: CVS tip problems at 2004-06-01 07:23:07 from Oliver Elphick

pgsql-hackers by date

Next:	From: Merlin Moncure	Date: 2004-06-01 14:39:31
	Subject: Re: [pgsql-hackers-win32] select like...not using index
Previous:	From: Tom Lane	Date: 2004-06-01 13:42:46
	Subject: Re: Fast index build vs. PITR

pgsql-patches by date

Next:	From: Euler Taveira de Oliveira	Date: 2004-06-01 19:12:55
	Subject: small fix in FAQ
Previous:	From: Harald Fuchs	Date: 2004-06-01 08:10:38
	Subject: Re: pg_dump --comment?