Skip site navigation (1) Skip section navigation (2)

Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch
Date: 2007-04-04 15:39:56
Message-ID: 22177.1175701196@sss.pgh.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Zoltan Boszormenyi <zb(at)cybertec(dot)at> writes:
> Here's the new version with the modifications you requested.

I see another problem with this patch: the code added to
ATExecDropColumn is a crude hack.  It doesn't work anyway since this is
not the only possible way for columns to be dropped (another one that
comes to mind immediately is DROP TYPE ... CASCADE).  The only correct
way to handle things is to let the dependency mechanism do it.  I think
you would get the behavior you want if you make the generated columns
have AUTO rather than NORMAL dependencies on the columns they reference.

			regards, tom lane

In response to

Responses

pgsql-hackers by date

Next:From: Mark DilgerDate: 2007-04-04 15:41:19
Subject: Re: Bug in UTF8-Validation Code?
Previous:From: Tatsuo IshiiDate: 2007-04-04 15:33:40
Subject: Re: Bug in UTF8-Validation Code?

pgsql-patches by date

Next:From: Tom LaneDate: 2007-04-04 16:12:02
Subject: Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch
Previous:From: Zoltan BoszormenyiDate: 2007-04-04 15:19:02
Subject: Re: IDENTITY/GENERATED v36 Re: Final version of IDENTITY/GENERATED patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group