From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, depesz <depesz(at)depesz(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] BUG #3799: csvlog skips some logs |
Date: | 2007-12-10 23:21:49 |
Message-ID: | 21540.1197328909@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Another change I did was to change a "%.*s" to "%*s". The "precision"
> marker seems useless AFAICT.
This is wrong, broken, will cause crashes on platforms where the PS
string is not null-terminated. (Hint: .* is a maximum width, * is a
minimum width.)
Another thing I thought strange was the order of the added columns;
why isn't it more like the order in which they appear in the text
version? In particular hint should probably come just after detail
and before context, and internal-query should also come before context
because when relevant it's usually more closely nested than the context
stack.
Otherwise the patch looks pretty sane to me. I didn't do any testing
though.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2007-12-11 13:46:16 | Re: [HACKERS] BUG #3799: csvlog skips some logs |
Previous Message | A. Ozen Akyurek | 2007-12-10 20:30:21 | BUG #3812: Delphi TADOStored procedure truncates time portion of the ftDateTime parameter using ODBC |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Chernow | 2007-12-10 23:23:53 | PGparam proposal |
Previous Message | Erik Jones | 2007-12-10 23:11:52 | Re: partitioned table query question |