Re: [BUGS] server crash in very big transaction [postgresql

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [BUGS] server crash in very big transaction [postgresql
Date: 2004-08-29 15:07:53
Message-ID: 20491.1093792073@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> On Wed, Aug 25, 2004 at 11:21:49AM +1000, Gavin Sherry wrote:
>> On Tue, 24 Aug 2004, Tom Lane wrote:
>>> Or we could assign an rmgr value to represent an "extension" record that
>>> is to be merged with a following "normal" record. This is kinda klugy
>>> but would avoid wasting bits on xl_len in the vast majority of records.
>>> Also we'd not have to force an initdb since the file format would
>>> remain upward-compatible.
>>
>> This is a better idea, I think, as it avoids the problems above and, as
>> you say, will be binary compatible.

> I also think this is a good idea. Would it be generalized or only
> applicable to xl_xact_{commit,abort} records?

After looking into this I've decided that it's not very practical --- it
would require major rewriting of XLogInsert, which I'm disinclined to do
at this stage of the beta cycle. Widening the xl_len field seems much
safer. It's not really an initdb-forcing change anyway; all you need to
do to upgrade an existing 8.0beta1 installation is run pg_resetxlog
(assuming you shut down the old postmaster cleanly).

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2004-08-29 16:11:28 Re: Update with join ignores where clause - updates all rows
Previous Message Bruce Momjian 2004-08-29 03:13:38 Re: pgsql 8.0 beta1 patch for token and timezone

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2004-08-29 16:05:55 Re: Contrib -- PostgreSQL shared variables
Previous Message Greg Stark 2004-08-29 14:42:55 Re: Contrib -- PostgreSQL shared variables