Re: Problem with ControlFileData structure being ABI depe ndent

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Dave Page <dpage(at)postgresql(dot)org>
Cc: Gregory Stark <stark(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Rainer Bauer <usenet(at)munnin(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Problem with ControlFileData structure being ABI depe ndent
Date: 2007-12-07 15:37:45
Message-ID: 20299.1197041865@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Dave Page <dpage(at)postgresql(dot)org> writes:
> Gregory Stark wrote:
>> An alternative is leaving it in the project file but putting something like
>> this in c.h:

Put it in win32.h, please. c.h shouldn't get cluttered with
platform-specific kluges when there's no need for it.

Is there a good reason not to just #define _USE_32BIT_TIME_T in win32.h?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dave Page 2007-12-07 15:38:37 Re: Possible PostgreSQL 8.3beta4 bug with MD5 authentication in psql?
Previous Message Mark Cave-Ayland 2007-12-07 15:27:02 Possible PostgreSQL 8.3beta4 bug with MD5 authentication in psql?

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Page 2007-12-07 16:00:49 Re: Problem with ControlFileData structure being ABI depe ndent
Previous Message Tom Lane 2007-12-07 15:15:35 Re: Proposed patch to make mergejoin cost estimation more symmetric