Re: perltidy

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: perltidy
Date: 2011-11-29 02:58:32
Message-ID: 201111290258.pAT2wWd14556@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut wrote:
> How much do we care about applying perltidy, as described in
> src/tools/msvc/README, everywhere? I just ran it across the entire
> tree, using
>
> perltidy -b -bl -nsfs -naws -l=100 -ole=unix **/*.pl **/*.pm
>
> and it generated 6531 lines of (unified) diff, of which 357 are in
> src/tools/msvc/ itself. So clearly it's not being applied very
> consistently.
>
> Given how easily this appears to work and how we're sneakily expanding
> the use of Perl, I think we ought to add this to the standard pgindent
> routine.

I have moved the Perl indentation command-line docs into the pgindent
README and it will be run as part of the pgindent checklist. Applied
patch attached.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
/rtmp/perl text/x-diff 1.2 KB

In response to

  • perltidy at 2011-06-14 19:30:41 from Peter Eisentraut

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2011-11-29 03:00:17 Re: Avoiding repeated snapshot computation
Previous Message Bruce Momjian 2011-11-29 02:49:03 Re: WIP: collect frequency statistics for arrays