Re: [GENERAL] pg_upgrade problem

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: depesz(at)depesz(dot)com
Cc: PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: [GENERAL] pg_upgrade problem
Date: 2011-09-01 01:54:20
Message-ID: 201109010154.p811sKm18831@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers

hubert depesz lubaczewski wrote:
> On Wed, Aug 31, 2011 at 01:23:05PM -0400, Bruce Momjian wrote:
> > Can you get me the 9.0.X pg_class.relfrozenxid for the toast and heap
> > tables involved?
>
> Sure:
>
> =# select oid::regclass, relfrozenxid from pg_class where relname in ('transactions', 'pg_toast_106668498');
> oid | relfrozenxid
> -----------------------------+--------------
> pg_toast.pg_toast_106668498 | 3673553926
> transactions | 3623560321
> (2 rows)

Working with depesz, I have found the cause. The code I added to fix
pg_upgrade in 9.0.4 and earlier releases didn't handle old 8.3 servers
properly. I mistakenly processed toast table with the same pg_dump
query as used for pre-8.4 toast tables, not realizing those were not
functional because there were no reloptions for toast tables in pre-8.4.

The attached applied patches fix all releases. This will have to be
mentioned in the 9.0.5 release notes, and we should probably do the same
kind of announcement we did when I fixed this for 9.0.4. :-(

Yeah, I should not have caused this bug. It did not show up in any of
my testing.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ It's impossible for everything to be true. +

Attachment Content-Type Size
/rtmp/pg_upgrade_fix.8.4 text/x-diff 2.2 KB
/rtmp/pg_upgrade_fix.9.0 text/x-diff 2.1 KB
/rtmp/pg_upgrade_fix.9.1 text/x-diff 2.0 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Bruce Momjian 2011-09-01 01:56:59 Re: [GENERAL] pg_upgrade problem
Previous Message David Johnston 2011-08-31 23:40:14 Re: ARRAY_AGG(DISTINCT a ORDER BY b) Error

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2011-09-01 01:56:59 Re: [GENERAL] pg_upgrade problem
Previous Message Tom Lane 2011-09-01 01:48:20 Re: [PATCH] Generate column names for subquery expressions