Skip site navigation (1) Skip section navigation (2)

Re: pg_upgrade and PGCLIENTENCODING

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_upgrade and PGCLIENTENCODING
Date: 2011-03-30 21:41:53
Message-ID: 201103302141.p2ULfrJ29439@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Peter Eisentraut wrote:
> On ons, 2011-03-30 at 15:42 -0400, Bruce Momjian wrote:
> > Peter Eisentraut wrote:
> > > pg_upgrade complains if any of the libpq connection variables are set.
> > > That's probably reasonable by default, but it seems to me that we ought
> > > to allow keeping PGCLIENTENCODING set, otherwise various values and
> > > error messages that are coming from the servers will not be in the
> > > encoding appropriate for the terminal.
> > 
> > What is the error message?  I don't see pg_upgrade checking
> > PGCLIENTENCODING.  I do check the cluster encodings.
> 
> It's done via check_for_libpq_envvars().
> 
> Actually, this is particular issue is new in 9.1, because the client
> encoding wasn't a connection option before.

Oh, we just blanket refuse any variable.  OK.  If you think it is safe,
feel free to apply a patch to skip it, or I can.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + It's impossible for everything to be true. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2011-03-30 21:44:13
Subject: Re: Problem with pg_upgrade?
Previous:From: Bruce MomjianDate: 2011-03-30 21:35:50
Subject: Re: Problem with pg_upgrade?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group