Skip site navigation (1) Skip section navigation (2)

Re: and it's not a bunny rabbit, either

From: David Fetter <david(at)fetter(dot)org>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>,Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: and it's not a bunny rabbit, either
Date: 2010-12-29 22:14:35
Message-ID: 20101229221435.GU25421@fetter.org (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Dec 29, 2010 at 04:53:47PM -0500, Robert Haas wrote:
> On Wed, Dec 29, 2010 at 4:09 AM, Heikki Linnakangas
> <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> > On 29.12.2010 06:54, Robert Haas wrote:
> >>
> >>  With the patch:
> >>
> >> rhaas=# cluster v;
> >> ERROR:  views do not support CLUSTER
> >
> > "do not support" sounds like a missing feature, rather than a nonsensical
> > command. How about something like "CLUSTER cannot be used on views"
> 
> In the latest version of this patch, I created four translatable
> strings per object type:
> 
> <blats> do not support %s (where %s is an SQL command)
> <blats> do not support constraints
> <blats> do not support rules
> <blats> do not support triggers
> 
> It's reasonable enough to write "CLUSTER cannot be used on views", but
> does "constraints cannot be used on views" seems more awkward to me.
> Or do we think that's OK?

That particular one looks good insofar as it describes reality.  With
predicate locks, etc., it may become untrue later, though :)

Cheers,
David.
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-hackers by date

Next:From: Robert TreatDate: 2010-12-29 22:19:18
Subject: understanding minimum recovery ending location
Previous:From: Dimitri FontaineDate: 2010-12-29 22:01:12
Subject: Upgrading Extension, version numbers (was: Extensions, patch v16)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group