Skip site navigation (1) Skip section navigation (2)

pgsql: Fix possible corruption of AfterTriggerEventLists in

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix possible corruption of AfterTriggerEventLists in
Date: 2010-08-19 15:46:18
Message-ID: 20100819154618.C63B37541D7@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix possible corruption of AfterTriggerEventLists in subtransaction rollback.

afterTriggerInvokeEvents failed to adjust events->tailfree when truncating
the last chunk of an event list.  This could result in the data being
"de-truncated" by afterTriggerRestoreEventList during a subsequent
subtransaction abort.  Even that wouldn't kill us, because the re-added data
would just be events marked DONE --- unless the data had been partially
overwritten by new events.  Then we might crash, or in any case misbehave
(perhaps fire triggers twice, or fire triggers with the wrong event data).
Per bug #5622 from Thue Janus Kristensen.

Back-patch to 8.4 where the current trigger list representation was introduced.

Modified Files:
--------------
    pgsql/src/backend/commands:
        trigger.c (r1.264 -> r1.265)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/trigger.c?r1=1.264&r2=1.265)

pgsql-committers by date

Next:From: Tom LaneDate: 2010-08-19 15:46:24
Subject: pgsql: Fix possible corruption of AfterTriggerEventLists in
Previous:From: David E. WheelerDate: 2010-08-19 15:09:36
Subject: Re: Re: [COMMITTERS] pgsql: Coerce 'unknown' type parameters to the right type in the

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group