Skip site navigation (1) Skip section navigation (2)

Re: Adding xpath_exists function

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Mike Fowler <mike(at)mlfowler(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding xpath_exists function
Date: 2010-05-31 16:58:12
Message-ID: 201005311658.o4VGwCR15031@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-rrreviewers
Mike Fowler wrote:
> Robert Haas wrote:
> > Please email your patch to the list (replying to this email is fine)
> > and add it here:
> > https://commitfest.postgresql.org/action/commitfest_view/open
> >   
> Here's my patch, developed against HEAD, that adds the function 
> 'xpath_exists'. The function is a lot simpler than originally thought, 
> so none of the string manipulation previously discussed was required. 
> I've also included some regression tests that test the function with and 
> without xml namespaces. I should  note that before I added my tests all 
> existing tests passed.
> 
> One observation that can be made is that I've largely copied the 
> existing xpath function and altered it to use a different method from 
> the libxml API. I've done it to save me redoing all the namespace 
> handling, however it's apparent to me that if we wanted to expose more 
> of the libxml api we will quickly start having a lot of duplicate code. 
> I notice that refactoring existing code whilst adding new code is 
> generally frowned upon, so once this patch is accepted I will look to 
> refactor the xpath and xpath_exists function. I could even add an 
> xpath_count method at the same time ;) .
> 
> Thanks in advance for any and all feedback,

I have added this to the next commit-fest:

	https://commitfest.postgresql.org/action/commitfest_view?id=6

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +


In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2010-05-31 17:05:52
Subject: Re: 9.0b1: "ERROR: btree index keys must be ordered by attribute"
Previous:From: Bruce MomjianDate: 2010-05-31 16:35:32
Subject: Re: functional call named notation clashes with SQL feature

pgsql-rrreviewers by date

Next:From: Kevin GrittnerDate: 2010-06-14 16:25:34
Subject: Reviewfest 2010-06 Plans and Call for Reviewers
Previous:From: Jaime CasanovaDate: 2010-05-24 19:08:40
Subject: Re: Heads up! Review fest starting June 15

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group