Mike Fowler wrote:
> Robert Haas wrote:
> > Please email your patch to the list (replying to this email is fine)
> > and add it here:
> > https://commitfest.postgresql.org/action/commitfest_view/open
> >   
> Here's my patch, developed against HEAD, that adds the function 
> 'xpath_exists'. The function is a lot simpler than originally thought, 
> so none of the string manipulation previously discussed was required. 
> I've also included some regression tests that test the function with and 
> without xml namespaces. I should  note that before I added my tests all 
> existing tests passed.
> 
> One observation that can be made is that I've largely copied the 
> existing xpath function and altered it to use a different method from 
> the libxml API. I've done it to save me redoing all the namespace 
> handling, however it's apparent to me that if we wanted to expose more 
> of the libxml api we will quickly start having a lot of duplicate code. 
> I notice that refactoring existing code whilst adding new code is 
> generally frowned upon, so once this patch is accepted I will look to 
> refactor the xpath and xpath_exists function. I could even add an 
> xpath_count method at the same time ;) .
> 
> Thanks in advance for any and all feedback,

I have added this to the next commit-fest:

	https://commitfest.postgresql.org/action/commitfest_view?id=6

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + None of us is going to be here forever. +

In response to

• Re: Adding xpath_exists function at 2010-05-11 09:21:43 from Mike Fowler

Responses

• [PATCH] Re: Adding xpath_exists function at 2010-06-27 16:09:21 from Mike Fowler

pgsql-hackers by date

Next:	From: Bruce Momjian	Date: 2010-05-31 17:05:52
	Subject: Re: 9.0b1: "ERROR: btree index keys must be ordered by attribute"
Previous:	From: Bruce Momjian	Date: 2010-05-31 16:35:32
	Subject: Re: functional call named notation clashes with SQL feature

pgsql-rrreviewers by date

Next:	From: Kevin Grittner	Date: 2010-06-14 16:25:34
	Subject: Reviewfest 2010-06 Plans and Call for Reviewers
Previous:	From: Jaime Casanova	Date: 2010-05-24 19:08:40
	Subject: Re: Heads up! Review fest starting June 15