Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Add psql tab completion for DO blocks.

From: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Add psql tab completion for DO blocks.
Date: 2010-02-15 09:27:12
Message-ID: 20100215182702.9DD0.52131E4D@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> itagaki(at)postgresql(dot)org (Takahiro Itagaki) writes:
> This syntax synopsis is completely nuts:
> DO { [ LANGUAGE lang_name ] | code } ...
> 
> I think that it would be logically correct without the square brackets,

Oops, that's correct.

> but as a matter of clarity I really doubt it's an improvement over the
> original.

We cannot write down the accurate syntax with BNF, right? We can have
0..1 "LANGUAGE lang_name", but must have just 1 "code" in any order.

How about the following description?

    DO [ LANGUAGE lang_name ] code

because the psql tab completion adds LANGUAGE just after DO.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center



In response to

pgsql-hackers by date

Next:From: Leonardo FDate: 2010-02-15 09:33:34
Subject: Re: [FWD] About "Our CLUSTER implementation is pessimal" patch
Previous:From: Heikki LinnakangasDate: 2010-02-15 09:16:58
Subject: Re: [FWD] About "Our CLUSTER implementation is pessimal" patch

pgsql-committers by date

Next:From: marcin mankDate: 2010-02-15 09:36:40
Subject: Re: [COMMITTERS] pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after
Previous:From: Andres FreundDate: 2010-02-15 08:36:31
Subject: Re: [COMMITTERS] pgsql: Speed up CREATE DATABASE by deferring the fsyncs until after

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group