Bruce Momjian <bruce(at)momjian(dot)us> wrote:

> Where are we on this patch?  We should at least implement the completion
> for 'LANGUAGE' in 'DO', and use the existing pg_language query for
> completion.  I am attaching a patch that does exactly this.

I don't think we need the patch except adding DO to the top-level sql_commands.

Syntax of DO command is:
    DO code [ LANGUAGE lang_name ]
We need 'code' before LANGUAGE, but the patch completes "DO" to "DO LANGUAGE".
It will be just a syntax error.

Also, we've already had a completion after LANGUAGE (see words_after_create),
so we don't need an additional Query_for_list_of_languages after LANGUAGE.


BTW, I'm working on psql tab-completion adjustment for new syntax in 9.0.
I'll send it soon.

Regards,
---
Takahiro Itagaki
NTT Open Source Software Center

In response to

• Re: psql tab completion for DO blocks at 2010-02-06 19:11:03 from Bruce Momjian

Responses

• Re: psql tab completion for DO blocks at 2010-02-11 00:21:25 from Bruce Momjian
• Re: psql tab completion for DO blocks at 2010-02-11 20:27:41 from David Fetter

pgsql-hackers by date

Next:	From: Takahiro Itagaki	Date: 2010-02-10 02:07:53
	Subject: psql tab-completion for new syntax
Previous:	From: Tom Lane	Date: 2010-02-10 01:41:14
	Subject: Re: Listen / Notify - what to do when the queue is full