Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without

From: Tatsuo Ishii <ishii(at)postgresql(dot)org>
To: heikki(dot)linnakangas(at)enterprisedb(dot)com
Cc: masao(dot)fujii(at)gmail(dot)com, simon(at)2ndquadrant(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Date: 2010-02-03 10:19:19
Message-ID: 20100203.191919.64297734.t-ishii@sraoss.co.jp (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
> Fujii Masao wrote:
> > On Mon, Feb 1, 2010 at 7:40 PM, Heikki Linnakangas
> > <heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> >> So you get those messages when the table is *not* a temporary table. I
> >> can see now what Fujii was trying to say. His patch seems Ok, though
> >> perhaps it would be better to move the responsibility of calling
> >> XLogReportUnloggedStatement() to the callers of heap_sync(). When I put
> >> it in heap_sync(), I didn't take into account that it's sometimes called
> >> just to flush buffers from buffer cache, not to fsync() non-WAL-logged
> >> operations.
> > 
> > As you said, I moved the responsibility of calling XLogReportUnloggedStatement()
> > to the callers of heap_sync(). Here is the patch.
> 
> Committed. The use_wal parameter to end_heap_rewrite() was not
> necessary, that information is already in RewriteState, so I took that out.

Are we going to bump up frontend/backend protocol version 3.0 to 3.x
or some such?
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese: http://www.sraoss.co.jp

In response to

Responses

pgsql-hackers by date

Next:From: Marko TiikkajaDate: 2010-02-03 10:31:03
Subject: Re: Review of Writeable CTE Patch
Previous:From: Simon RiggsDate: 2010-02-03 10:05:29
Subject: Re: pgsql: Assorted cleanups in preparation for using a map file to support

pgsql-committers by date

Next:From: Heikki LinnakangasDate: 2010-02-03 10:50:06
Subject: Re: Re: [COMMITTERS] pgsql: Write a WAL record whenever we perform an operation without
Previous:From: Simon RiggsDate: 2010-02-03 10:05:29
Subject: Re: pgsql: Assorted cleanups in preparation for using a map file to support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group