Skip site navigation (1) Skip section navigation (2)

Re: plpgsql: open for execute - add USING clause

From: Takahiro Itagaki <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: plpgsql: open for execute - add USING clause
Date: 2010-01-14 01:34:21
Message-ID: 20100114103421.9A0E.52131E4D@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackers
Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> wrote:

> ok, I accept all comments.
> revised version are attached.

Good. This patch is ready to commit. I'll do it soon if no objections.

BTW, I found inconsistent parameter dumps in the codes. Some of them
add '$', but others does not. Are they intentional? Or, should we
adjust them to use one of the formats?

[pl_funcs.c]
dump_dynexecute()
dump_raise()
			printf("    parameter %d: ", i++);
dump_dynfors()
dump_open()
dump_return_query()
			printf("    parameter $%d: ", i++);


Regards,
---
Takahiro Itagaki
NTT Open Source Software Center



In response to

Responses

pgsql-hackers by date

Next:From: KaiGai KoheiDate: 2010-01-14 01:46:07
Subject: Re: [PATCH] remove redundant ownership checks
Previous:From: Robert HaasDate: 2010-01-14 01:32:22
Subject: last CommitFest coming up in just under 24 hours

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group