Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than
Date: 2010-01-07 03:41:41
Message-ID: 201001070341.o073ff609931@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Alvaro Herrera wrote:
> Bruce Momjian wrote:
> > Alvaro Herrera wrote:
>
> > > I think this is a bad style to use for commit messages. For GIT, a good
> > > commit message is a first line being a summary, and a more extensive
> > > message below.
> >
> > That is just too odd. I think I forgot about the summary idea then.
>
> What is odd?
>
> If I was unclear, look at this status page:
>
> http://git.postgresql.org/gitweb?p=postgresql.git;a=shortlog
>
> Note that for your commit it only says "PG_MAJORVERSION:". You have to
> open the patch's page to see the rest of the message.

Well, having the description and then a blank line in the middle just is
too odd for too small a group of viewers. I might as well just type the
commit message as normal and users can see all they can.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2010-01-07 03:49:18 Re: pgsql: PG_MAJORVERSION: For simplicity, use PG_MAJORVERSION rather than
Previous Message Robert Haas 2010-01-07 03:37:10 Re: [COMMITTERS] pgsql: Support ALTER TABLESPACE name SET/RESET ( tablespace_options ).