Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Provide rowcount for utility SELECTs

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Boszormenyi Zoltan <zb(at)cybertec(dot)at>, Peter Eisentraut <peter_e(at)gmx(dot)net>,Hans-Juergen Schoenig <hs(at)cybertec(dot)at>,Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Provide rowcount for utility SELECTs
Date: 2009-12-29 13:35:52
Message-ID: 20091229133551.GB4569@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane escribió:
> Boszormenyi Zoltan <zb(at)cybertec(dot)at> writes:
> > Tom Lane rta:
> >> It's more the possibility of doing strcmp(tag, "SELECT") on the command
> 
> > Actually it's strncmp(tag, "SELECT ", 7), so when you mix old server
> > with new clients or new server with old client, it will just work as
> > before, i.e. return "".
> 
> Are you deliberately ignoring the point?  We have no way to know whether
> there is any client-side code that's doing a simple check for SELECT
> command tag, but it's certainly possible.  The fact that it wouldn't be
> hard to fix does not mean that it wouldn't be broken.

But it would be broken in very obvious ways, no?  It's not like it would
be silently broken and thus escape testing ...

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: mattDate: 2009-12-29 14:30:00
Subject: Re: parse tree to XML format
Previous:From: Alvaro HerreraDate: 2009-12-29 13:33:17
Subject: Re: Add subdirectory support for DATA/DOCS with PGXS

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group