Skip site navigation (1) Skip section navigation (2)

pgsql: Change CREATE TABLE so that column default expressions coming

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Change CREATE TABLE so that column default expressions coming
Date: 2009-10-06 00:55:35
Message-ID: 20091006005535.35C5D753FB7@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Change CREATE TABLE so that column default expressions coming from different
inheritance parent tables are compared using equal(), instead of doing
strcmp() on the nodeToString representation.  The old implementation was
always a tad cheesy, and it finally fails completely as of 8.4, now that the
node tree might contain syntax location information.  equal() knows it's
supposed to ignore those fields, but strcmp() hardly can.  Per recent
report from Scott Ribe.

Tags:
----
REL8_4_STABLE

Modified Files:
--------------
    pgsql/src/backend/commands:
        tablecmds.c (r1.288.2.1 -> r1.288.2.2)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/tablecmds.c?r1=1.288.2.1&r2=1.288.2.2)
    pgsql/src/backend/nodes:
        copyfuncs.c (r1.432 -> r1.432.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/copyfuncs.c?r1=1.432&r2=1.432.2.1)
        equalfuncs.c (r1.355 -> r1.355.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/equalfuncs.c?r1=1.355&r2=1.355.2.1)
        outfuncs.c (r1.360 -> r1.360.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/nodes/outfuncs.c?r1=1.360&r2=1.360.2.1)
    pgsql/src/backend/parser:
        parse_utilcmd.c (r2.21 -> r2.21.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/parser/parse_utilcmd.c?r1=2.21&r2=2.21.2.1)
    pgsql/src/include/nodes:
        parsenodes.h (r1.395 -> r1.395.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/parsenodes.h?r1=1.395&r2=1.395.2.1)
    pgsql/src/test/regress/expected:
        inherit.out (r1.26 -> r1.26.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/inherit.out?r1=1.26&r2=1.26.2.1)
    pgsql/src/test/regress/sql:
        inherit.sql (r1.12 -> r1.12.2.1)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/sql/inherit.sql?r1=1.12&r2=1.12.2.1)

pgsql-committers by date

Next:From: User DimDate: 2009-10-06 09:55:33
Subject: prefix - prefix: Release 1.0.0
Previous:From: Tom LaneDate: 2009-10-06 00:55:26
Subject: pgsql: Change CREATE TABLE so that column default expressions coming

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group