Skip site navigation (1) Skip section navigation (2)

Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)
Date: 2009-08-11 19:28:26
Message-ID: 20090811192826.GC16362@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Andrew Dunstan escribió:
> 
> 
> Tom Lane wrote:
> >Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> >>Robert Haas wrote:
> >>>Where it really bit me as when it reindented the DATA() statements
> >>>that were touched by ALTER TABLE ... SET STATISTICS DISTINCT.  It's
> >>>not so hard to compare code, but comparing DATA() lines is the pits.
> >
> >>Oh? Maybe that's a problem we need to address more directly. I
> >>just looked at what it did to the DATA lines - it seems to have
> >>changed 501 of them, and all the changes seem to be to do with
> >>tabbing.
> >
> >That's interesting --- the whitespace in those macros has always been
> >wildly inconsistent, so I assumed pgindent wasn't touching them at all.
> >I wonder what it thinks it's doing...
> 
> Here's the extract attached.  I replace tabs with a literal '\t' so
> I could see what it was doing. I can't make much head or tail of it
> either.

pgindent uses entab/detab, which counts spaces and replaces them with
tabs.  It is wildly undocumented.  See src/tools/entab

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Mark MielkeDate: 2009-08-11 19:34:03
Subject: Re: "Hot standby"?
Previous:From: Andrew DunstanDate: 2009-08-11 19:19:01
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

pgsql-committers by date

Next:From: User FxjrDate: 2009-08-11 19:46:51
Subject: npgsql - Npgsql2: Fixed bug when trying to retrieve a date value with
Previous:From: Andrew DunstanDate: 2009-08-11 19:19:01
Subject: Re: Re: pgindent timing (was Re: [COMMITTERS] pgsql: Refactor NUM_cache_remove calls in error report path to a PG_TRY)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group