Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > We should call [Read dumpfile] routine only once even on Windows.
> Seems to me that you should simply do the load only when found is false.
Here is a patch to fix pg_stat_statements on Windows.
I see we don't need any locks because initialization is done in postmaster;
There are no chance to see uninitialized state of 'pgss' after relasing
AddinShmemInitLock and before load dumpfile into it.
I also check pgss_shmem_shutdown and no problem.
It is called only once from postmaster on shutdown.
NTT Open Source Software Center
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2009-07-27 03:05:05|
|Subject: Re: autogenerating headers & bki stuff|
|Previous:||From: Robert Haas||Date: 2009-07-27 02:52:24|
|Subject: Re: generic explain options v3|
pgsql-bugs by date
|Next:||From: Alvaro Herrera||Date: 2009-07-27 03:30:42|
|Subject: Re: BUG #4941: pg_stat_statements crash|
|Previous:||From: Federico Aguirre||Date: 2009-07-27 02:33:43|
|Subject: BUG #4942: edb_apachephp.bin error|