On Sun, Jun 14, 2009 at 05:59:58PM +0200, Petr Jelinek wrote:
> David Fetter wrote:
>> I was discussing this with Andrew Gierth in IRC, who thought that
>> putting RETURNING inside the WITH clause would be relatively easy, at
>> least for the parser and planner. For the executor, he suggested that
>> one approach might be to make INSERT, UPDATE and DELETE into their own
> David asked me to post his (and mine) experimental work in progress
> patch for this here. The patch in the current state does not work. It
> dies in executor on:
> ERROR: attribute 1 has wrong type
> DETAIL: Table has type tid, but query expects integer.
> Since I know nothing about postgres' executor I am only guessing it
> thinks the query is SELECT instead of DELETE RETURNING.
> Also I think those query->commandType == CMD_SELECT ? query->targetList
> : query->returningList in several places might not be the right way to
I went another way in the attached patch, and thanks :)
> Anyway it's beginning and maybe somebody who knows what he is doing
> could help or continue the work.
This patch fails regression tests and hangs or crashes when attempting
to do a writeable CTE.
Any help getting it into better shape would be greatly appreciated :)
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
In response to
pgsql-hackers by date
|Next:||From: Robert Haas||Date: 2009-06-15 01:11:41|
|Subject: Re: machine-readable explain output|
|Previous:||From: Erik Rijkers||Date: 2009-06-14 20:31:48|
|Subject: 8.4 release notes "Recursive Joins"|
pgsql-general by date
|Next:||From: Tom Lane||Date: 2009-06-14 22:36:33|
|Subject: Re: running pg_dump from python |
|Previous:||From: Garry Saddington||Date: 2009-06-14 21:50:32|
|Subject: Re: running pg_dump from python|