Alvaro Herrera wrote:
> Alvaro Herrera wrote:
> > Hmm, oh I see another problem here -- the bit is not restored when
> > replayed heap_update's WAL record. I'm now wondering what other bits
> > are set without much care about correctly restoring them during replay.
> I'm now wondering whether it'd be easier to just ignore pd_flags in
> calculating the checksum.
Okay, so this is what I've done. pd_flags is skipped. Also the WAL
routine logs both HeapTupleHeader infomasks and ItemId->lp_flags. On
the latter point I'm not 100% sure of the cases where lp_flags must be
logged; right now I'm only logging if the item is marked as "having
storage" (the logic being that if an item does not have storage, then
making it have requires a WAL entry, and vice versa).
(This version has some debugging log entries which are obviously only
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
In response to
pgsql-hackers by date
|Next:||From: Tom Lane||Date: 2008-11-07 19:15:38|
|Subject: Re: [RRR] Tests citext casts |
|Previous:||From: Tom Lane||Date: 2008-11-07 18:58:04|
|Subject: Re: Distinct types |