Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alex Hunsaker <badalex(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Patches <pgsql-patches(at)postgresql(dot)org>, "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout
Date: 2008-06-23 22:51:28
Message-ID: 200806232251.m5NMpSD25633@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Alex Hunsaker wrote:
> On Wed, Apr 16, 2008 at 4:54 PM, Alvaro Herrera
> <alvherre(at)commandprompt(dot)com> wrote:
> > Joshua D. Drake escribi?:
> >
> > > That is an interesting idea. Something like:
> >  >
> >  > pg_restore -E "SET STATEMENT_TIMEOUT=0; SET MAINTENANCE_WORK_MEM=1G" ?
> >
> >  We already have it -- it's called PGOPTIONS.
> >
> 
> Ok but is not the purpose of the patch to turn off statement_timeout
> by *default* in pg_restore/pg_dump?
> 
> Here is an updated patch for I posted above (with the command line
> option --use-statement-timeout) for pg_dump and pg_restore.

I would like to get do this without adding a new --use-statement-timeout
flag.  Is anyone going to want to honor statement_timeout during
pg_dump/pg_restore?  I thought we were just going to disable it.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2008-06-23 22:59:01
Subject: Re: [PATCHES] Testing pg_terminate_backend()
Previous:From: Bruce MomjianDate: 2008-06-23 22:42:38
Subject: Re: Timely reporting of COPY errors

pgsql-patches by date

Next:From: Bruce MomjianDate: 2008-06-23 22:59:01
Subject: Re: [PATCHES] Testing pg_terminate_backend()
Previous:From: Andrew DunstanDate: 2008-06-23 22:01:04
Subject: Re: variadic function support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group