Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Removing typename from A_Const (was: Emptyarrays with ARRAY[])

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Brendan Jurd <direvus(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Removing typename from A_Const (was: Emptyarrays with ARRAY[])
Date: 2008-04-28 16:54:34
Message-ID: 20080428165434.GD5761@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane escribió:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
> > Brendan Jurd escribi:
> >> Here's my attempt to remove the typename field from A_Const.  There
> >> were a few places (notably flatten_set_variable_args() in guc.c, and
> >> typenameTypeMod() in parse_type.c) where the code expected to see an
> >> A_Const with a typename, and I had to adjust for an A_Const within a
> >> TypeCast.  Nonetheless, there was an overall net reduction of 34 lines
> >> of code, so I think this was a win.
> 
> > Do say ... why don't we do away with A_Const altogether and just replace
> > it with Value?  After this patch, I don't see what's the difference.
> 
> They're logically different things, and after I get done putting a parse
> location field into A_Const, they'll still be physically different too.

Aha.  Are you working from Brendan's patch?  I was going to commit it.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2008-04-28 17:05:38
Subject: Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Previous:From: Tom LaneDate: 2008-04-28 16:50:18
Subject: Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])

pgsql-patches by date

Next:From: Tom LaneDate: 2008-04-28 17:05:38
Subject: Re: [HACKERS] Removing typename from A_Const (was: Empty arrays with ARRAY[])
Previous:From: Tom LaneDate: 2008-04-28 16:50:18
Subject: Re: Removing typename from A_Const (was: Empty arrays with ARRAY[])

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group