Re: 64-bit CommandIds

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Hans-Juergen Schoenig <hs(at)cybertec(dot)at>
Subject: Re: 64-bit CommandIds
Date: 2008-04-24 17:44:27
Message-ID: 200804241744.m3OHiR824199@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


So, is this an option we want for configure?

---------------------------------------------------------------------------

Zoltan Boszormenyi wrote:
> Alvaro Herrera ?rta:
> > Zoltan Boszormenyi wrote:
> >
> >
> >> attached is our patch against HEAD which enables extending CommandIds
> >> to 64-bit. This is for enabling long transactions that really do that much
> >> non-read-only work in one transaction.
> >>
> >
> > I think you should add a pg_control field and corresponding check, to
> > avoid a 64bit-Cid postmaster to start on a 32bit-Cid data area and vice
> > versa.
> >
>
> I added the check but I needed to add it BEFORE checking for
> toast_max_chunk_size otherwise it complained about this more
> cryptic problem. I think it's cleaner to report this failure to know
> why toast_max_chunk_size != TOAST_MAX_CHUNK_SIZE.
>
> Best regards,
> Zolt?n B?sz?rm?nyi
>
> --
> ----------------------------------
> Zolt?n B?sz?rm?nyi
> Cybertec Sch?nig & Sch?nig GmbH
> http://www.postgresql.at/
>

>
> --
> Sent via pgsql-patches mailing list (pgsql-patches(at)postgresql(dot)org)
> To make changes to your Subscription:
> http://mail.postgresql.org/mj/mj_wwwusr?domain=postgresql.org&extra=pgsql-patches

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2008-04-24 17:49:19 Re: Proposed patch - psql wraps at window width
Previous Message Gregory Stark 2008-04-24 17:34:31 Re: Proposed patch - psql wraps at window width