Skip site navigation (1) Skip section navigation (2)

Re: Proposed patch - psql wraps at window width

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Bryce Nesbitt <bryce2(at)obviously(dot)com>, pgsql-patches(at)postgresql(dot)org, heikki(at)enterprisedb(dot)com
Subject: Re: Proposed patch - psql wraps at window width
Date: 2008-04-17 12:34:52
Message-ID: 20080417123452.GC3846@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian wrote:

> In testing I found the regression tests were failing because of a divide
> by zero error (fixed), and a missing case where the column delimiter has
> to be ":".  In fact I now see all your line continuation cases using ":"
> rather than "!".  It actually looks better --- "!" was too close to "|"
> to be easily recognized.  (Did you update your patch to use ":".  I
> didn't see "!" in your patch.)

I think we should use a different separator when there is an actual
newline in the data.  Currently we have a : there, so using a : here is
probably not the best idea.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

pgsql-hackers by date

Next:From: Peter EisentrautDate: 2008-04-17 12:39:43
Subject: get rid of psql welcome message
Previous:From: Alvaro HerreraDate: 2008-04-17 12:30:12
Subject: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit couldleave shared memory

pgsql-patches by date

Next:From: Peter EisentrautDate: 2008-04-17 13:09:23
Subject: Re: Proposed patch - psql wraps at window width
Previous:From: Brendan JurdDate: 2008-04-17 08:48:42
Subject: Re: printTable API (was: Show INHERIT in \du)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group