Skip site navigation (1) Skip section navigation (2)

Re: Suppress compiler warnings on mingw

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-patches(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeremy Drake <pgsql(at)jdrake(dot)com>
Subject: Re: Suppress compiler warnings on mingw
Date: 2008-03-17 03:04:08
Message-ID: 20080317115020.652C.52131E4D@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-patches
Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> Then try using %lu and no casts.  That should get rid of the warnings the 
> proper way.

Ok, I rewrote it to use %lu for format strings.


Jeremy Drake <pgsql(at)jdrake(dot)com> wrote:
> sizeof(DWORD) is always 4, even on 64-bit windows.  sizeof(long) is also
> always 4.

I got it. This change will work on 64-bit windows, because DWORD is
defined as 'unsigned long' there, too. We need to support LLP64
compliers in advance, though.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center



Attachment: mingw-warnings.patch
Description: application/octet-stream (4.6 KB)

In response to

Responses

pgsql-patches by date

Next:From: Kohei KaiGaiDate: 2008-03-17 04:25:40
Subject: [0/4] Proposal of SE-PostgreSQL patches
Previous:From: Tom LaneDate: 2008-03-17 02:53:02
Subject: Re: updated hash functions for postgresql v1

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group