Skip site navigation (1) Skip section navigation (2)

Re: Auto-explain patch

From: David Fetter <david(at)fetter(dot)org>
To: Dean Rasheed <dean_rasheed(at)hotmail(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Auto-explain patch
Date: 2008-01-28 20:08:00
Message-ID: 20080128200800.GE21175@fetter.org (view raw or flat)
Thread:
Lists: pgsql-patches
On Mon, Jan 28, 2008 at 07:55:53PM +0000, Dean Rasheed wrote:
> 
> > Dean,
> >
> > Maybe I missed something obvious here, but how does this patch handle
> > the situation where people have turned on INTEGER_DATETIMES?
> >
> > Cheers,
> > David.
> > --
> > David Fetter  http://fetter.org/
> > Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
> > Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
> >
> > Remember to vote!
> > Consider donating to Postgres: http://www.postgresql.org/about/donate
> 
> Sorry, I don't understand. I am new to this code, but I can't see
> how the INTEGER_DATETIMES flag will affect this code. I am using the
> macros and functions from instrument.h and explain.c for timing,
> which appear to use gettimeofday() or QueryPerformanceCounter(),
> coverting the result to a double to report the total time spent
> running the query.

It's the double part I don't quite get.  Shouldn't that be an int64 in
the case of INTEGER_DATETIMES?

Cheers,
David.

> 
> As far as I can see, the INTEGER_DATETIMES flag doesn't affect this
> code. Am I missing something?

> 
> Dean.
> 
> _________________________________________________________________
> Free games, great prizes - get gaming at Gamesbox. 
> http://www.searchgamesbox.com
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778  AIM: dfetter666  Yahoo!: dfetter
Skype: davidfetter      XMPP: david(dot)fetter(at)gmail(dot)com

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2008-01-28 20:20:59
Subject: Re: [PATCHES] Friendly help for psql
Previous:From: Dean RasheedDate: 2008-01-28 19:55:53
Subject: Re: Auto-explain patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group