Skip site navigation (1) Skip section navigation (2)

pgsql: Fix a conceptual error in my patch of 2007-10-26 that avoided

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix a conceptual error in my patch of 2007-10-26 that avoided
Date: 2008-01-11 04:02:26
Message-ID: 20080111040226.1951A754108@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix a conceptual error in my patch of 2007-10-26 that avoided considering
clauseless joins of relations that have unexploited join clauses.  Rather
than looking at every other base relation in the query, the correct thing is
to examine the other relations in the "initial_rels" list of the current
make_rel_from_joinlist() invocation, because those are what we actually have
the ability to join against.  This might be a subset of the whole query in
cases where join_collapse_limit or from_collapse_limit or full joins have
prevented merging the whole query into a single join problem.  This is a bit
untidy because we have to pass those rels down through a new PlannerInfo
field, but it's necessary.  Per bug #3865 from Oleg Kharin.

Tags:
----
REL8_2_STABLE

Modified Files:
--------------
    pgsql/src/backend/optimizer/path:
        allpaths.c (r1.154.2.1 -> r1.154.2.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/allpaths.c?r1=1.154.2.1&r2=1.154.2.2)
        joinrels.c (r1.81.2.4 -> r1.81.2.5)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/path/joinrels.c?r1=1.81.2.4&r2=1.81.2.5)
    pgsql/src/backend/optimizer/plan:
        planmain.c (r1.97.2.1 -> r1.97.2.2)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/planmain.c?r1=1.97.2.1&r2=1.97.2.2)
    pgsql/src/include/nodes:
        relation.h (r1.128.2.4 -> r1.128.2.5)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/nodes/relation.h?r1=1.128.2.4&r2=1.128.2.5)

pgsql-committers by date

Next:From: User NickgDate: 2008-01-11 04:45:21
Subject: press - pr: Corrected features83 hyperlink
Previous:From: Tom LaneDate: 2008-01-11 04:02:18
Subject: pgsql: Fix a conceptual error in my patch of 2007-10-26 that avoided

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group