Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Improve wording.

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Martijn van Oosterhout <kleptog(at)svana(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgsql: Improve wording.
Date: 2007-12-22 05:14:01
Message-ID: 200712220514.lBM5E1719644@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Alvaro Herrera wrote:
> Martijn van Oosterhout wrote:
> > On Mon, Dec 17, 2007 at 01:48:31PM +0000, Alvaro Herrera wrote:
> > > Log Message:
> > > -----------
> > > Improve wording.
> 
> > I'd suggest removing everything between the parentheses, or perhaps
> > something like: By tracking allocated memory  rather than used memory
> > it removes the possibilty of failing in a page fault. This option also
> > require you allocate enoghh swap to cover all possible eventualities,
> > though in production it will not be used.
> 
> I agree that the parenthised phrase should be removed.
> 
> http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/runtime.sgml?r1=1.387&r2=1.391
> 
> I think your proposed wording is removed enough from what the
> complainant was saying that it is not worth to stick it in.  The point
> here is, to what extent do we want to spoon-feed careless sysadmins?

OK, I have removed the paratheses paragraph about fork() and added link
to an article about the OOM:

    http://lwn.net/Articles/104179/

    On Linux 2.6 and later, an additional measure is to modify the
    kernel's behavior so that it will not <quote>overcommit</> memory.
    Although this setting will not prevent the <ulink
    url="http://lwn.net/Articles/104179/">OOM killer</> from being invoked
    altogether, it will lower the chances significantly and will therefore
    lead to more robust system behavior.  This is done by selecting strict
    overcommit mode via <command>sysctl</command>:

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-12-22 05:15:04
Subject: Re: pgsql: Improve wording.
Previous:From: Andrew ChernowDate: 2007-12-22 03:42:23
Subject: timetz range check issue

pgsql-committers by date

Next:From: Bruce MomjianDate: 2007-12-22 05:15:04
Subject: Re: pgsql: Improve wording.
Previous:From: Bruce MomjianDate: 2007-12-22 05:13:03
Subject: pgsql: Remove paragraph about Linux OOM killer and fork().

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group