Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] BUG #3799: csvlog skips some logs

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, depesz <depesz(at)depesz(dot)com>, pgsql-bugs(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] BUG #3799: csvlog skips some logs
Date: 2007-12-10 15:11:44
Message-ID: 20071210151144.GE8036@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-hackers
Andrew Dunstan wrote:

> Not sure I understand what this comment I noticed on a very brief glance is 
> about:
>
>  /* assume no newlines in funcname or filename... */
>
> If it's about what to quote, we need to quote anything that might contain a newline, quote or comma. Filenames certainly come into that category.

Huh, sorry, that's a leftover comment.  The inserted string is quoted
inside appendCSVLiteral.  Thanks, I'll fix it.

-- 
Alvaro Herrera                 http://www.amazon.com/gp/registry/DXLWNGRJD34J
"No es bueno caminar con un hombre muerto"

In response to

Responses

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2007-12-10 15:14:55
Subject: Re: [HACKERS] BUG #3799: csvlog skips some logs
Previous:From: Gregory StarkDate: 2007-12-10 15:05:04
Subject: O(n^2) aggregates

pgsql-bugs by date

Next:From: Alvaro HerreraDate: 2007-12-10 15:14:55
Subject: Re: [HACKERS] BUG #3799: csvlog skips some logs
Previous:From: Andrew DunstanDate: 2007-12-10 15:04:46
Subject: Re: [HACKERS] BUG #3799: csvlog skips some logs

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group