Skip site navigation (1) Skip section navigation (2)

Re: pgwin32_open returning EINVAL

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>,Martijn van Oosterhout <kleptog(at)svana(dot)org>,Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgwin32_open returning EINVAL
Date: 2007-11-30 11:17:05
Message-ID: 20071130111705.GA21642@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Nov 29, 2007 at 05:48:23PM -0500, Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Tom Lane wrote:
> >> Well, since EINVAL is the default result from _dosmaperr, and none of
> >> the cases it represents are "expected", why don't we just remove all of
> >> the explicit mappings to EINVAL from doserrors[]?
> 
> > Well, the problematic routine is not already using _dosmaperr currently.
> > It is doing it's own mapping and neglecting to report anything.
> 
> Oh, well then why are we arguing?  There is no reason at all to assume
> that _dosmaperr wouldn't give us a sufficiently good fix on the error
> if it were only being used.  At the very least, I think we should put
> in Magnus' patch and find out whether it gives sufficient information.
> If it doesn't, then we can think about changing to a higher log level.

Applied.

//Magnus

In response to

pgsql-hackers by date

Next:From: Magnus HaganderDate: 2007-11-30 11:28:20
Subject: Re: Time to update list of contributors
Previous:From: Simon RiggsDate: 2007-11-30 10:24:06
Subject: Re: Release Note Changes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group