Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Extract catalog info for error reportingbefore an error actually

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org, Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Extract catalog info for error reportingbefore an error actually
Date: 2007-10-25 16:41:50
Message-ID: 20071025164150.GF23566@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches
Simon Riggs wrote:
> On Thu, 2007-10-25 at 14:45 +0000, Alvaro Herrera wrote:
> > Log Message:
> > -----------
> > Extract catalog info for error reporting before an error actually happens.
> > Also, remove redundant reset of for-wraparound PGPROC flag.
> 
> Just noticed you've made these changes. I was working on them, but
> hadn't fully tested the patch because of all the different touch points.
> Sorry for the delay.
> 
> Would you like me to refresh my earlier patch against the newly
> committed state (or did you commit that aspect already as well?).

I am doing just that.  I'll post it soon.

FWIW I disagree with cancelling just any autovac work automatically; in
my patch I'm only cancelling if it's analyze, on the grounds that if
you have really bad luck you can potentially lose a lot of work that
vacuum did.  We can relax this restriction when we have cancellable
vacuum.

-- 
Alvaro Herrera                         http://www.flickr.com/photos/alvherre/
"La principal característica humana es la tontería"
(Augusto Monterroso)

In response to

Responses

pgsql-hackers by date

Next:From: Simon RiggsDate: 2007-10-25 16:56:30
Subject: Re: pgsql: Extract catalog info for error reportingbefore an error actually
Previous:From: Andrew DunstanDate: 2007-10-25 16:31:30
Subject: module archive

pgsql-committers by date

Next:From: Simon RiggsDate: 2007-10-25 16:56:30
Subject: Re: pgsql: Extract catalog info for error reportingbefore an error actually
Previous:From: Simon RiggsDate: 2007-10-25 15:54:23
Subject: Re: pgsql: Extract catalog info for error reportingbefore an error actually

pgsql-patches by date

Next:From: Simon RiggsDate: 2007-10-25 16:56:30
Subject: Re: pgsql: Extract catalog info for error reportingbefore an error actually
Previous:From: Simon RiggsDate: 2007-10-25 15:54:23
Subject: Re: pgsql: Extract catalog info for error reportingbefore an error actually

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group