Re: Various fixes for syslogger

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Various fixes for syslogger
Date: 2007-09-21 01:07:36
Message-ID: 20070921094602.68C0.ITAGAKI.TAKAHIRO@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:

> > - syslogger_parseArgs_assert.patch (bug #3621)
> > The assertion in syslogger_parseArgs() was wrong. The number of
> > arguments passed to syslogger is changed to 4 in 8.1 or later.
> > This patch should be appled to 8.1, 8.2 and 8.3dev.
> >
> Can you pinpoint where this change in argv/argc was made? I'm having
> trouble locating it.

Oops, I misread the codes. There was the same bug in 8.0, too.
Therefore, the fix should be appled to 8.0, 8.1, 8.2 and 8.3dev.
We've had the bug in all versions after syslogger was added.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Joshua D. Drake 2007-09-21 01:10:07 Re: Patch to update log levels
Previous Message Tom Lane 2007-09-21 01:02:11 Re: Patch to update log levels