Skip site navigation (1) Skip section navigation (2)

Re: Correction of how to use TimeZone by ControlFile(xlog.c)

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Hiroshi Saito <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Correction of how to use TimeZone by ControlFile(xlog.c)
Date: 2007-08-03 11:44:11
Message-ID: 20070803114411.GD30042@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-patches
On Wed, Aug 01, 2007 at 11:17:21AM +0900, Hiroshi Saito wrote:
> >"Hiroshi Saito" <z-saito(at)guitar(dot)ocn(dot)ne(dot)jp> writes:
> >>[ patch to use pg_strftime in xlog.c ]
> >
> >This code deliberately does not use pg_strftime, for the same reasons
> >that elog.c doesn't use it.
> >
> >I'm inclined to think that an appropriate fix is the same as we use in
> >elog.c, ie, don't use %Z at all under Windows.
> 
> Eh? Do you mean this change? 
> "%Y-%m-%d %H:%M:%S %Z" to "%Y-%m-%d %H:%M:%S"
> That tzname is expressed here does not regard me as a problem.
> Probably, elog.c has still more nearly another problem.

Having talked a bit off-list with Hiroshi-san, he came up with the
suggestion taht we should be logging this information in UTC/GMT instead of
the servers timezone (for all cases, not just win32). That would make
things equally "safe" wrt changes in the pg timezone, and always
predictable. 

Thoughts on this?

//Magnus

In response to

Responses

pgsql-patches by date

Next:From: Andrew DunstanDate: 2007-08-03 13:01:22
Subject: Re: Correction of how to use TimeZone by ControlFile(xlog.c)
Previous:From: Hiroshi SaitoDate: 2007-08-03 11:22:40
Subject: Re: [PATCHES] patch win32.mak of libpq

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group