Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Create hooks to let a loadable plugin monitor (or even replace)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)postgresql(dot)org>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Create hooks to let a loadable plugin monitor (or even replace)
Date: 2007-05-29 19:06:46
Message-ID: 200705291906.l4TJ6kT23732@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Gurjeet Singh wrote:
> I like the new interface... it supports all the current Index Advisor
> requirements, and probably the future requirements too.
> 
> I'll submit a new patch taking the current support routines into
> consideration.
> 
> But I did not understand the haste to commit the patch within almost half an
> hour of proposing the second version of the patch!!!

It happens some times when a patch applier has gotten as far as they can
go with a patch and wants to move on, with the willingness to return to
the patch if there is any additional feedback.

---------------------------------------------------------------------------


> -- 
> gurjeet[(dot)singh](at)EnterpriseDB(dot)com
> singh(dot)gurjeet(at){ gmail | hotmail | yahoo }.com
> 
> 17?29'34.37"N  78?30'59.76"E - Hyderabad *
> 18?32'57.25"N  73?56'25.42"E - Pune
> 
> Sent from my BlackLaptop device
> 
> On 5/25/07, Tom Lane <tgl(at)postgresql(dot)org> wrote:
> >
> > Log Message:
> > -----------
> > Create hooks to let a loadable plugin monitor (or even replace) the
> > planner
> > and/or create plans for hypothetical situations; in particular,
> > investigate
> > plans that would be generated using hypothetical indexes.  This is a
> > heavily-rewritten version of the hooks proposed by Gurjeet Singh for his
> > Index Advisor project.  In this formulation, the index advisor can be
> > entirely a loadable module instead of requiring a significant part to be
> > in the core backend, and plans can be generated for hypothetical indexes
> > without requiring the creation and rolling-back of system catalog entries.
> >
> > The index advisor patch as-submitted is not compatible with these hooks,
> > but it needs significant work anyway due to other 8.2-to-8.3 planner
> > changes.  With these hooks in the core backend, development of the advisor
> > can proceed as a pgfoundry project.
> >
> > Modified Files:
> > --------------
> >     pgsql/src/backend/commands:
> >         explain.c (r1.163 -> r1.164)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/explain.c.diff?r1=1.163&r2=1.164
> > )
> >         prepare.c (r1.75 -> r1.76)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/prepare.c.diff?r1=1.75&r2=1.76
> > )
> >     pgsql/src/backend/executor:
> >         nodeBitmapIndexscan.c (r1.22 -> r1.23)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeBitmapIndexscan.c.diff?r1=1.22&r2=1.23
> > )
> >         nodeIndexscan.c (r1.121 -> r1.122)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeIndexscan.c.diff?r1=1.121&r2=1.122
> > )
> >     pgsql/src/backend/optimizer/plan:
> >         planner.c (r1.219 -> r1.220)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/planner.c.diff?r1=1.219&r2=1.220
> > )
> >     pgsql/src/backend/optimizer/util:
> >         plancat.c (r1.134 -> r1.135)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/plancat.c.diff?r1=1.134&r2=1.135
> > )
> >     pgsql/src/include/commands:
> >         explain.h (r1.30 -> r1.31)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/commands/explain.h.diff?r1=1.30&r2=1.31
> > )
> >     pgsql/src/include/optimizer:
> >         plancat.h (r1.43 -> r1.44)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/plancat.h.diff?r1=1.43&r2=1.44
> > )
> >         planner.h (r1.39 -> r1.40)
> >         (
> > http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/optimizer/planner.h.diff?r1=1.39&r2=1.40
> > )
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 2: Don't 'kill -9' the postmaster
> >

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Josh BerkusDate: 2007-05-29 19:36:39
Subject: Re: Fixing insecure security definer functions
Previous:From: Magnus HaganderDate: 2007-05-29 18:40:05
Subject: Padding on 64-bit

pgsql-committers by date

Next:From: User PgunittestDate: 2007-05-29 19:07:11
Subject: pgunittest - pgUnitTest:
Previous:From: User PgunittestDate: 2007-05-29 19:06:20
Subject: pgunittest - pgUnitTest: New Directory

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group