Skip site navigation (1) Skip section navigation (2)

Re: ECPG failure on BF member Vaquita (Windows Vista)

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>,Mark Wong <markwkm(at)gmail(dot)com>,Michael Meskes <meskes(at)postgresql(dot)org>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ECPG failure on BF member Vaquita (Windows Vista)
Date: 2007-04-26 10:07:41
Message-ID: 20070426100741.GB14147@feivel.credativ.de (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Apr 25, 2007 at 04:38:30PM -0400, Tom Lane wrote:
> My recommendation is to get rid of the APREF hack, deal only in
> va_list not &va_list, and inline ECPGget_variable into the two
> places it's used to avoid the question of passing va_lists around
> after they've been modified.  The routine's not that big (especially
> seeing that only half of it is actually shared by the two callers)
> and it's just not worth the notational effort, let alone any portability
> risks, to factor it out.

Having spend countless hours debugging this stuff I fully agree with
you. It's not just ECPGget_variable though. I also had to inline
create_statement. This is only called once, so no big deal, but the
calling function gets bigger by quite a margin that way. It was
definitely easier to read with these functions, but again all this
hassle isn't worth it.

Attached you'll find a patch that should inline both functions and
remove the APREF stuff. This successfully runs the regression suite on
my Linux box. Please test it on those archs that needed special
treatment before I commit.

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

Responses

pgsql-hackers by date

Next:From: Zeugswetter Andreas ADI SDDate: 2007-04-26 10:42:41
Subject: Re: too much WAL volume
Previous:From: Michael MeskesDate: 2007-04-26 09:30:04
Subject: Re: ECPG failure on BF member Vaquita (Windows Vista)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group