Skip site navigation (1) Skip section navigation (2)

Re: log_autovacuum

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Simon Riggs <simon(at)2ndquadrant(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: log_autovacuum
Date: 2007-04-17 22:18:04
Message-ID: 20070417221804.GH15495@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-patchespgsql-www
Alvaro Herrera wrote:
> Tom Lane wrote:
> > BTW, shouldn't the log entry distinguish whether this was VACUUM,
> > ANALYZE, or both?
> 
> We don't actually log anything for ANALYZE (the logging code is in
> lazy_vacuum_rel).
> 
> Maybe it should be in autovacuum.c.

The only problem with this is that we would have to export struct
LVRelStats definition from vacuumlazy.c and pass the struct back ...
which wouldn't directly work on ANALYZE.  What we could do is pass back
a "void *" pointer, which lazyvacuum.c or the analyze code knows how to
turn into a string.

I have no problem both ways.  Here is the current patch (logging code
still in lazy_vacuum_rel, log_autovacuum morphed into an integer
variable).

Opinions?

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment: log-autovacuum.patch
Description: text/x-diff (6.1 KB)

In response to

Responses

pgsql-www by date

Next:From: Tom LaneDate: 2007-04-17 22:32:26
Subject: Re: log_autovacuum
Previous:From: Simon RiggsDate: 2007-04-17 20:48:48
Subject: Re: log_autovacuum

pgsql-patches by date

Next:From: Tom LaneDate: 2007-04-17 22:32:26
Subject: Re: log_autovacuum
Previous:From: Simon RiggsDate: 2007-04-17 20:48:48
Subject: Re: log_autovacuum

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group