Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Arrays of Complex Types

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: David Fetter <david(at)fetter(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Arrays of Complex Types
Date: 2007-04-03 02:01:44
Message-ID: 20070403020143.GA8484@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian wrote:
> 
> Your patch has been added to the PostgreSQL unapplied patches list at:
> 
> 	http://momjian.postgresql.org/cgi-bin/pgpatches
> 
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.
> 

So, hum, what happened to the idea of creating the array types only on
demand?

> 
> 
> David Fetter wrote:
> > On Fri, Mar 30, 2007 at 05:08:42PM -0400, Tom Lane wrote:
> > > David Fetter <david(at)fetter(dot)org> writes:
> > > > After several rounds of patches, it appears that it might be easier to
> > > > create a new typtype entry, which I'll tentatively call 'a' because it
> > > > seems a little fragile and a lot inelegant and hard to maintain to
> > > > have typtype='c' and typrelid=InvalidOid mean, "this is an array of
> > > > complex types."
> > > 
> > > Uh, wouldn't it be typtype = 'c' and typelem != 0 ?
> > 
> > Right.  The attached patch passes the current regression tests and at
> > least to a "smoke test" level does what it's supposed to do.  I'd
> > really like to help refactor the whole array system to use 'a', tho.
> > 
> > Cheers,


-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Andrew DunstanDate: 2007-04-03 02:05:50
Subject: Re: Feature thought: idle in transaction timeout
Previous:From: Joshua D. DrakeDate: 2007-04-03 01:59:29
Subject: Re: Feature thought: idle in transaction timeout

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-04-03 04:13:13
Subject: Re: xpath_array with namespaces support
Previous:From: Bruce MomjianDate: 2007-04-03 01:25:53
Subject: Re: COPY-able sql log outputs

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group